-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 compatible, Recalc improved, progress bars fixed #296
Conversation
mortii
commented
Aug 10, 2023
•
edited
Loading
edited
- Now works on the V3 scheduler (fixes 2021 (v3) scheduler support #276)
- Exponentially faster recalc action
- Progress dialogs are now shown when recalcing and anki no longer freezes (background thread is used instead of main thread)
- Renamed some files that were poorly named
- Refactored init file and extracted hidden hooks to make the code execution logic much clearer
- Added some type hints for clearer logic
- refactored some variable names to follow PEP conventions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, I appreciate the attention to detail like renaming variables.
I'm happy to merge it if you can address the linter warnings.
Also, the master
branch is outdated. The latest version on AnkiWeb is using the qt6-migration
branch. I'll merge your changes into that branch after it gets merged to master.
I fixed the lint errors and I rebased onto qt6-migration |
hold on, a very a sneaky error appeared that needs to be fixed |
- Now works on the V3 scheduler - Exponentially faster recalc action - Progress dialogs are now shown when recalcing and anki no longer freezes (background thread is used instead of main thread) - Renamed some files that were poorly named - Refactored init file and extracted hidden hooks to make the code execution logic much clearer - Added some type hints for clearer logic - refactored some variable names to follow PEP conventions
there was an invisible input parameter after removing a lambda, but it's fixed now. |
Also this should probably be placed in the ankiweb description until we get a proper wiki/guide (next on my todo-lis):
The writing is kinda clunky, feel free to improve it in whatever way you see fit , lol. |
Looks good to me, thanks for all the work you did here. |
Thank you so much for your work. I am the version of QT5. I tried to modify:
to:
it works! |
Awesome, I really appreciate the report! If this is really all that's needed, I should be able to modify the UI generation code to replace these imports with the aqt version and have full backwards compatibility. |