Inject data only when renders via Meteor

[delgermurun]

Don't inject when server side rendering.

[arunoda]

Thanks for switching the issue.
I think I can check for something else or track if there are some data.
(Let's see)

On Mon, Apr 20, 2015 at 1:39 PM Delgermurun Purevkhuu <
[email protected]> wrote:

Don't inject when server side rendering.

—
Reply to this email directly or view it on GitHub
#108.

[timbrandin]

Is there a way I can take a look at this?

[arunoda]

Actual code is in the inject data package. See: https://github.com/meteorhacks/inject-data/blob/master/lib/server.js#L29

We currently look it by the DOCTYPE and that's the issue.
If we can look for some other text which send by meteor initial page everytime, that's an easy fix.

[arunoda]

Or may be you can remove that route from fast-render support.
Don't know that's possible.

[timbrandin]

Just my thought, we should look for the escaped_fragment and don't support those routes

[arunoda]

Okay. That's a good point. We can remove that from google's bot.
For that check here: http://goo.gl/Rw2XQU

Then how about SSR?

[timbrandin]

Hmm, what do you mean? Like server side for any other request made by a server?

[arunoda]

I mean HTML pages generated via may be my SSR package or via react or something. May be this is something for future discussion. Currently, I like the escape fragment check.

[timbrandin]

meteorhacks/inject-data#2

[timbrandin]

Seems to be the case that Content-Type is set to text/html when the request is made from the browser, in the other case with "?escaped_fragment=" it's not there. Could this work for the other use cases too @arunoda ?

[arunoda]

Let's move the discussion there.

On Fri, May 1, 2015 at 5:49 PM Tim Brandin [email protected] wrote:

Seems to be the case that Content-Type is set to text/html when the
request is made from the browser, in the other case with "?
escaped_fragment=" it's not there. Could this work for the other use
cases too @arunoda https://github.com/arunoda ?

—
Reply to this email directly or view it on GitHub
#108 (comment)
.

[arunoda]

I did some changes to make sure fast render runs only for HTML page requests.
That might fixed that. Check the latest version.
See: 9203dcb