payload: index more tables and quit writing JSON/base64 payloads #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoughtpolice
force-pushed
the
aseipp/push-sutyrksrttut
branch
from
6d87506 to
27393c2
Compare
thoughtpolice
force-pushed
the
aseipp/push-sutyrksrttut
branch
from
27393c2 to
b483f02
Compare
Signed-off-by: Austin Seipp <[email protected]> Change-Id: I7a8d1d83453d021c01aca3b8e9c2318d16d6461d
Do not export intermediate payload store function, only export the top-level `newTransactionDb` and `newPayloadDb` methods. Instead, move these into `where` blocks so they are scoped appropriately. This does not change any behavior, because no external clients actually called any of these. As a bonus, it also means we can remove the now-pointless 'db' parameter to most functions, since they have it available in their closure. Signed-off-by: Austin Seipp <[email protected]> Change-Id: Id1096eb1720a1c309ef808af6610bf986821941a
thoughtpolice
force-pushed
the
aseipp/push-sutyrksrttut
branch
from
b483f02 to
2db2973
Compare
Signed-off-by: Austin Seipp <[email protected]> Change-Id: I832611067595ae19b6deeb5e8faf68ec367e7b1e
thoughtpolice
force-pushed
the
aseipp/push-sutyrksrttut
branch
from
2db2973 to
4cd0f1a
Compare
edmundnoble
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.