HLS integration fixes for the chainweb-data codebase #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit works around the following HLS bug: haskell/haskell-language-server#481 That issue is actually related to stack, but seems like the cabal integration is suffering from the same in our case. There are quite a few relative-path related issue open HLS anyway. This commit uses the `makeRelativeToProject` function from file-embed in order to resolve the relative paths in a way that's independent of the build system, working around this long-standing HLS bug.
enobayram
requested review from
mightybyte,
sirlensalot and
buckie
as code owners
emmanueldenloye
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
hie.yamlto the project and also works around the following HLS bug:haskell/haskell-language-server#481
That issue is actually related to stack, but seems like the cabal integration is suffering from the same in our case. There are quite a few relative-path related issues open in HLS anyway.
This commit uses the
makeRelativeToProjectfunction from file-embed (As suggested by phadej under another issue) in order to resolve the relative paths in a way that's independent of the build system, working around this long-standing HLS bug.