Optimize the recent transactions query #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we're reading the tx height from the transaction itself, we don't have any reason left to JOIN on the blocks table
enobayram
added a commit
that referenced
this pull request
Mar 24, 2023
This PR removes the recentTxs tracking from the CW-D server state and always makes a DB query when recent transactions are needed. With the current indexes that we have in place, the recent txs query is very fast to execute (see #119), so there's no need to complicate the server state for it anymore. Note that, in addition to simplifying the codebase, this PR is also needed for the continuations search improvements mentioned [here](#66 (comment)) as well as for the planned work of decoupling the node listener from the HTTP API server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the "recent transactions" query performed by chainweb-data at server start up. Before this PR, the query used the blocks.height column to order the query results, but we currently don't have an index on that column, so this query resulted in a full scan of the blocks table and unnecessarily delayed the server start up by a considerable amount of time.
This PR fixes that issue by instead using the transfers.height column which is supposed to have the same value and is also indexed.