Feature/crosschain-transactions #10
Conversation
…ransaction Initial crosschain transaction implementation
…plement-activity-list-user-feedback-for-crosschain
…ferent-chain Bug/send same account different chain; Some other small UI fixes
…plement-activity-list-user-feedback-for-crosschain
…activity-list-user-feedback-for-crosschain Identifying in the activities when a transaction is Crosschain
… into feature/kad-13-implement-activity-list-user-feedback-for-crosschain
Feature/cross chain ledger
… into feature/kad-31-fix-wording-when-its-sendingreceiving-and-fix-sign-check-if
…ommunity/enKrypt into feature/crosschain-transactions
… into feature/kad-31-fix-wording-when-its-sendingreceiving-and-fix-sign-check-if
…ng-when-its-sendingreceiving-and-fix-sign-check-if Feature/kad 31 fix wording when its sendingreceiving and fix sign check if
…rdware wallet message from crosschain transaction verification
…ommunity/enKrypt into feature/crosschain-transactions
KevinKons
changed the title
KevinKons
changed the title
| } | ||
| if (!toAccount && activity.crossChainAccount) { | ||
| toAccount = activity.crossChainAccount; | ||
| const groupActivities = activities |
There was a problem hiding this comment.
this can be simplified:
const groupdActivities = activities.reduce((acc: any, activity: any) => {
if (activity.chain === chainId || activity.crossChainId === chainId) {
if (!acc[activity.requestKey] || activity.idx !== 0) {
acc[activity.requestKey] = activity;
}
}
return acc;
}, {});
| @@ -0,0 +1,327 @@ | |||
| // Copied from https://github.com/obsidiansystems/hw-app-kda/blob/develop/src/Kadena.ts | |||
There was a problem hiding this comment.
I see this file was copied over, but I would strongly reconsider this approach, if you copy code you also take on the burden of maintaining it, and this code is not maintainable. some notable issues across this file:
- No triple equals conditions used
- blake2b dependency is not in package.json
- Building a transaction with string concatenation is not acceptable
- Derivation path is incorrect: should be
m/44'/626'/0'instead ofm/44'/626'/0'/0/0 - Debug console.log's left in
|
There are eslint config files across the different packages, but a lot of them have significant amounts of errors and don't seem to be tested at all. |
|
I tried testing my ledger device on this branch, but it could not connect. Initially giving the error Because of this I could not test any of the ledger integration. |
|
|
||
| const gasLimit = transactionResult.metaData?.publicMeta?.gasLimit; | ||
| const gasPrice = transactionResult.metaData?.publicMeta?.gasPrice; | ||
| const gasFee = gasLimit && gasPrice ? gasLimit * gasPrice : 0; |
There was a problem hiding this comment.
I don't understand this gasFee calculation. gasLimit should not be part of it, that's just the upper limit of what can be spend on a transaction and has nothing to do with the actual fee.
| const gasLimit = transactionResult.metaData?.publicMeta?.gasLimit; | ||
| const gasPrice = transactionResult.metaData?.publicMeta?.gasPrice; | ||
| const gasFee = gasLimit && gasPrice ? gasLimit * gasPrice : 0; | ||
| gasFee = gasLimit && gasPrice ? gasLimit * gasPrice : 0; |
There was a problem hiding this comment.
Same comment as before, this is not a good calculation of gasFee.
|
|
||
| const gasLimit = transactionResult.metaData?.publicMeta?.gasLimit; | ||
| const gasPrice = transactionResult.metaData?.publicMeta?.gasPrice; | ||
| const gasFee = gasLimit && gasPrice ? gasLimit * gasPrice : 0; |
There was a problem hiding this comment.
Same comment as before, this is not a good calculation of gasFee.
No description provided.