Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused devcontainer #735

Merged
merged 1 commit into from
Mar 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .devcontainer/.config/nix/nix.conf

This file was deleted.

54 changes: 0 additions & 54 deletions .devcontainer/Dockerfile

This file was deleted.

10 changes: 0 additions & 10 deletions .devcontainer/README.md

This file was deleted.

3 changes: 0 additions & 3 deletions .devcontainer/bootstrap.bash

This file was deleted.

39 changes: 0 additions & 39 deletions .devcontainer/devcontainer.json

This file was deleted.

3 changes: 0 additions & 3 deletions .devcontainer/docker_build.bash

This file was deleted.

3 changes: 0 additions & 3 deletions .devcontainer/docker_shell.bash

This file was deleted.

5 changes: 0 additions & 5 deletions .devcontainer/setup_direnv.bash

This file was deleted.

5 changes: 0 additions & 5 deletions .devcontainer/shell.bash

This file was deleted.

44 changes: 0 additions & 44 deletions .github/workflows/ci-devcontainer.yml

This file was deleted.

3 changes: 0 additions & 3 deletions .github/workflows/itself.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,6 @@ jobs:
{
"workflowFile": "ci-nix.yml"
},
{
"workflowFile": "ci-devcontainer.yml"
},
{
"workflowFile": "merge-bot-pr.yml",
"jobName": "dependabot"
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,3 @@ jobs:
.
.github
.vscode
.devcontainer
16 changes: 0 additions & 16 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,6 @@
(prepared shell)
```

### Devcontainer/Docker

You can use Devcontainer or the Docker to skip installing Nix on your local machine.

[![Open in Dev Containers](https://img.shields.io/static/v1?label=Dev%20Containers&message=Open&color=blue&logo=visualstudiocode)](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/kachick/vwait-other-jobs) 🚶

Simulate devcontainer from docker as following.

```console
> ./.devcontainer/docker_build.bash
...
> ./.devcontainer/docker_shell.bash
vscode ➜ /workspaces/wait-other-jobs (main) $ makers check
...Done in...
```

### Tasks

```console
Expand Down
20 changes: 2 additions & 18 deletions Makefile.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ category = "Tools"
description = "Run formatters with changes"
script = [
"dprint fmt",
"typos . .github .vscode .devcontainer --write-changes",
"typos . .github .vscode --write-changes",
]

[tasks.lint]
Expand All @@ -22,9 +22,8 @@ description = "Run linters without changes"
script = [
"dprint check",
"deno lint",
"typos . .github .vscode .devcontainer",
"typos . .github .vscode",
"actionlint",
"trivy config --exit-code 1 .",
]

[tasks.test]
Expand Down Expand Up @@ -53,20 +52,6 @@ category = "Tools"
description = 'Parallel runner for all tests and linters'
run_task = { name = ["typecheck", "test", "lint", "build"], parallel = true }

[tasks.docker-build]
category = "Tools"
description = 'Build docker image for devcontainer'
script = [
"./.devcontainer/docker_build.bash",
]

[tasks.docker-shell]
category = "Tools"
description = 'Login to built container'
script = [
"./.devcontainer/docker_shell.bash",
]

[tasks.help]
category = "Tools"
description = 'Might help you - (This one)'
Expand All @@ -86,7 +71,6 @@ script = [
# Returns NON 0, why...? :<
# "nixpkgs-fmt --version",
"actionlint --version",
"trivy --version",
"typos --version",
]

Expand Down
8 changes: 4 additions & 4 deletions flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,22 @@
devShells.default = with pkgs;
mkShell {
buildInputs = [
# For Nix environments
# https://github.com/NixOS/nix/issues/730#issuecomment-162323824
bashInteractive
nil
nixpkgs-fmt

nodejs_20
deno
dprint
cargo-make
nil
nixpkgs-fmt
typos
actionlint

# For fighting the GitHub API
gh
jq

trivy
];
};
});
Expand Down
Loading