Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making false-positive errors since v3.0.0, if any specified jobs aren't ran #760

Closed
kachick opened this issue Apr 12, 2024 · 1 comment · Fixed by #762
Closed

Making false-positive errors since v3.0.0, if any specified jobs aren't ran #760

kachick opened this issue Apr 12, 2024 · 1 comment · Fixed by #762
Assignees
Labels
enhancement New feature or request

Comments

@kachick
Copy link
Owner

kachick commented Apr 12, 2024

What

Extracted from #754 (comment)

If "wait-list" is used, and that job doesn't run at all (in my case, the job I'm waiting for doesn't always need to run), we get: throw new Error("No targets found except wait-other-jobs itself"); I think perhaps the proper fix here, if possible, might be to add a third parameter to wait-list to indicate the job is optional, or (much easier) just an overall "jobs-might-not-exist" parameter that skips that Throw? Because if it's not

How

  • the guard message applied since 3.0.0, just dropping might be enough
  • add options to handle that?
@kachick kachick added the bug Something isn't working label Apr 12, 2024
@kachick kachick self-assigned this Apr 12, 2024
@kachick kachick added this to 🛸 Apr 12, 2024
@github-project-automation github-project-automation bot moved this to 🙋‍♂ in 🛸 Apr 12, 2024
@kachick kachick added enhancement New feature or request and removed bug Something isn't working labels Apr 12, 2024
@kachick kachick moved this from 🙋‍♂ to 💪 in 🛸 Apr 12, 2024
kachick added a commit that referenced this issue Apr 14, 2024
@github-project-automation github-project-automation bot moved this from 💪 to 🎉 in 🛸 Apr 14, 2024
@kachick
Copy link
Owner Author

kachick commented Apr 14, 2024

Add option to avoid this problem in #762 and released it with v3.1.0 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
1 participant