Integrate dprint-plugin-exec to use rubocop as a simple formatter #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachick
commented
Jan 24, 2023
| "exec": { | ||
| "associations": ["**/*.{rb,gemspec,rake}", "Rakefile", "Gemfile", "Steepfile"], | ||
| "rubocop": "bundle exec rubocop --autocorrect --stdin {{file_path}} --stderr", | ||
| "rubocop.associations": "**/**" |
There was a problem hiding this comment.
Because of no supported multiple globs yet https://github.com/dprint/dprint-plugin-exec/blob/94ed0fe3fac6a631c5e3e00538f29c30770a0738/src/configuration.rs#L165-L173
kachick
commented
Jan 24, 2023
| @@ -3,11 +3,16 @@ | |||
| }, | |||
| "markdown": { | |||
| }, | |||
| "exec": { | |||
| "associations": ["**/*.{rb,gemspec,rake}", "Rakefile", "Gemfile", "Steepfile"], | |||
| "rubocop": "bundle exec rubocop --autocorrect --stdin {{file_path}} --stderr", | |||
There was a problem hiding this comment.
Using servermode makde faster, However closing vscode does not kill it. So it should be done in another PR or commit.
kachick
added a commit
that referenced
this pull request
Jan 24, 2023
kachick
added a commit
that referenced
this pull request
Jan 24, 2023
kachick
added a commit
to kachick/ruby-gem-template
that referenced
this pull request
Feb 7, 2023
kachick
added a commit
to kachick/ruby-gem-template
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update #314 with https://github.com/dprint/dprint-plugin-exec
Much more simpler 🎉