Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript type definitions #578

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

TypeScript type definitions #578

wants to merge 2 commits into from

Conversation

corwin-of-amber
Copy link
Contributor

(still working on this branch, just letting you know)

I imported the definitions from DefinitelyTyped and added the missing constructor.
I am working on porting their tests to use tsd, theirs use dtslint which is a huge overkill.

@corwin-of-amber
Basic typings for nearley.
40288ff 
(Taken from DefinitelyTyped.)
@corwin-of-amber
Copy link
Contributor Author

BTW I see coffee-script referenced in coffee-script but no .coffee files. Looks like docopt is written in CoffeeScript but is already compiled to JS in the npm package, so perhaps this dep can be removed?

@corwin-of-amber
Copy link
Contributor Author

I added the test files and they look ok, to run them all that needs to be done is npx tsd. Should I add this command to the npm run test script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@corwin-of-amber