Big cleanup #11
Open
Big cleanup #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hides commands from players that are being controlled with iControlU.
Since we don't use NMS, this is harmless. Saves about 100ms of startup time on first boot on my machine
Finalizes everything, adds @NotNull to onCommand parameters, and uses pattern matching for the onCommand instanceof Player check.
This was done so spamming CommandSpy commands wouldn't lag the server as much, and having a bunch of players turn on CommandSpy wouldn't fill up the server storage.
We should probably keep kaboom plugins' API version synced with the main server
|
I hate to nag people, but this PR has been sitting here for a while. Bump. |
|
@kaboombot Bump |
1 similar comment
|
@kaboombot Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit names and descriptions for more info
Before:
After:
This would obviously scale with more spambots, and the lag would be way, way worse on actual Kaboom, as the hardware is much weaker than my computer.