cass-operator webhook fixes #415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miles-Garnsey
changed the title
Miles-Garnsey
force-pushed
the
cass-webhook-fixes
branch
from
a324194 to
66747bb
Compare
Miles-Garnsey
force-pushed
the
cass-webhook-fixes
branch
from
e7fce60 to
39700e4
Compare
|
Subject to tests passing I believe that this addresses the issues raised in #397 and is ready for review. |
|
OK @burmanm and @jsanda (whoever sees this first) this looks good to go IMO. Tests failing
Are we happy to approve or are there too many failing tests? |
|
This is covered in #365 so we'll close this PR and grab the change via the other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Bumps cass-operator version to a new version which has the right failure behaviour in the webhook (see this PR).
Fixes issues in the e2e tests which arise from the wrong namespace being specified for the
webhooks.0.clientConfig.service.namespace.Which issue(s) this PR fixes:
#397 originally talked about some problems with the
ValidatingWebhookConfiguration, these do not occur in real deployments, but will occur during tests.It has since been repurposed to focus on the e2e test kustomizations.
Checklist