Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SSAND-1779 ⁃ Upgrade to Go 1.18 and to operator-sdk 1.23 #681

Closed
jsanda opened this issue Sep 14, 2022 · 4 comments · Fixed by #694
Closed

K8SSAND-1779 ⁃ Upgrade to Go 1.18 and to operator-sdk 1.23 #681

jsanda opened this issue Sep 14, 2022 · 4 comments · Fixed by #694
Assignees
Labels
enhancement New feature or request zh:In-Progress Issues in the ZenHub pipeline 'In-Progress'

Comments

@jsanda
Copy link
Contributor

jsanda commented Sep 14, 2022

What is missing?
We are still on Go 1.17. Our Kubernetes dependencies are on 1.23.4. Based on here in the Makefile it looks like we are on operator-sdk v1.18.0. Going through the upgrade guide up through the latest release, which is v1.23.0, will move us to Go 1.18, update Kubernetes dependencies to 1.24, and update tooling dependencies like controller-gen.

For reference these changes have already been made in cass-operator in k8ssandra/cass-operator#399.

@burmanm A couple questions for you:

I believe operator-sdk v1.23.0 moves to Kustomize v4.5.5. Let's go ahead and move to v4.5.7 to be consistent with cass-operator.

Environment

  • K8ssandra Operator version:

    v1.2.0

@jsanda jsanda added enhancement New feature or request Epic labels Sep 14, 2022
@sync-by-unito sync-by-unito bot changed the title Upgrade to Go 1.18 and to operator-sdk 1.23 K8SSAND-1779 ⁃ Upgrade to Go 1.18 and to operator-sdk 1.23 Sep 14, 2022
@jsanda jsanda removed the Epic label Sep 14, 2022
@burmanm
Copy link
Contributor

burmanm commented Sep 15, 2022

Ah, the perf improvements were in 4.5.5, regardless - 4.5.6 / 4.5.7 has these improvement which we use a hacks for currently (name + namespace ambiquities, namespace transformer improvements for roles):

https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv4.5.6

(4.5.7 is a re-release of 4.5.6 which had a dependency bug)

@burmanm
Copy link
Contributor

burmanm commented Sep 15, 2022

For the k8s.io/kubernetes, here are the repository rules: https://github.com/kubernetes/community/blob/master/github-management/kubernetes-repositories.md

(Note the Core Repositories part). The github.com/kubernetes/kubernetes is a building part, and modules are placed under staging directory there.

It's funny that I can't find anywhere it documented, but here's from Kubernetes issue which is the sort of comment that's usually referred:

kubernetes/kubernetes#90358 (comment)

@jsanda
Copy link
Contributor Author

jsanda commented Sep 16, 2022

I want to point out that kubernetes/kubernetes#90358 (comment) actually states that depending on k8s.io/kubernetes is not supported.

@olim7t olim7t self-assigned this Sep 19, 2022
@olim7t
Copy link
Contributor

olim7t commented Sep 20, 2022

k8s.io/kubernetes is only used for hash.DeepHashObject, used here and here.

The implementation is pretty straightforward, and I think the licenses will allow us to copy it to our codebase.

-- edit: ah, that's what Michael already did in the other PR 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request zh:In-Progress Issues in the ZenHub pipeline 'In-Progress'
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants