Allow replacenode task to replace nodes that have Cassandra crashed #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…placement still happens (with PV volume check)
adejanovski
approved these changes
Apr 16, 2024
Comment on lines
299
to
300
| // Should we do it here? This is going to target just a single node in any case | ||
| // Validate the pod is a known one and get it |
There was a problem hiding this comment.
question: not sure what you want to express here? Is there some check you want to do here that you're doing somewhere else atm?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Modifies the replace pod process to be able to replace a node that has no longer a running Cassandra pod. Also, add a test to verify the PVs that the pod uses are different from previous ones in the replace node e2e test.
Which issue(s) this PR fixes:
Fixes #628
Checklist