Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused DSE_VERSION env variable #510

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Mar 20, 2023

What this PR does:
Removes the DSE_VERSION env variable, which is not used.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm burmanm requested a review from a team as a code owner March 20, 2023 13:00
@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall but there are two syntax issues with missing colons and some checks that are failing.

pkg/reconciliation/construct_podtemplatespec_test.go Outdated Show resolved Hide resolved
pkg/reconciliation/construct_podtemplatespec_test.go Outdated Show resolved Hide resolved
@burmanm burmanm merged commit 3cc1fd5 into k8ssandra:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants