Extend current ImageConfig to allow more values to images as well as … #505
Conversation
|
PR still missing modifications to ImagePullPolicy for certain imageTypes in the CassandraDatacenter spec.. |
burmanm
force-pushed
the
refactor_imageconfig
branch
from
3a90099 to
884800c
Compare
burmanm
force-pushed
the
refactor_imageconfig
branch
from
884800c to
2b79709
Compare
burmanm
force-pushed
the
refactor_imageconfig
branch
from
a714810 to
fb9eb8c
Compare
|
@burmanm, should we close this? |
|
You mean merge? We haven't merged any changes to master. |
|
no, I mean is it still something we want to do? |
Yes, in this PR, not anywhere else. We haven't changed imageConfig properties in anyway elsewhere. That includes HCD version overrides or namespace overrides for airgaps. They are all in this PR only. Do we not want those features anymore? I thought there was a customer request for the override namespace registry. |
…additional configuration options for each image type Add modified PullPolicy to containers Add ability to restrict pullSecrets added per pod Make internal imageConfig to be non-pointer to allow easier usage in tests Make some pointer accesses safer
burmanm
force-pushed
the
refactor_imageconfig
branch
from
74ec96d to
4f26efa
Compare
| imagePullPolicy: Always | ||
| imagePullSecret: | ||
| name: my-secret-pull-registry | ||
| imageNamespace: "enterprise" |
There was a problem hiding this comment.
Todo: let's make sure we expose these new fields in the Helm chart.
What this PR does:
Part of the implementation of k8ssandra/k8ssandra-operator#532
Which issue(s) this PR fixes:
Fixes k8ssandra/k8ssandra-operator#532
Fixes #636
Checklist