Run /start on the background for pods and up the timeout #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerkle826
approved these changes
Mar 8, 2023
berndocklin
reviewed
Mar 13, 2023
| "Starting Cassandra for pod %s", pod.Name) | ||
| err = mgmtClient.CallLifecycleStartEndpoint(pod) | ||
| } | ||
| go func(pod *corev1.Pod) { |
There was a problem hiding this comment.
I know, late comment, but it would have been great to see a comment here why this needs to run concurrently
There was a problem hiding this comment.
It's a background task to allow cass-operator to process next command. The Reconcile pattern should never block itself.
burmanm
added a commit
that referenced
this pull request
Mar 20, 2023
* Up Kustomize to 5.0.0 * CHANGELOG * Update golangci-lint to prevent OOM with go1.20 * If old version of golangci-lint is installed, remove it and install a new one * Fix the TestFailStart to take into account the async nature of start (cherry picked from commit a5a7908)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Increase the /start timeout from 10s to 10 mins, but run it on the background to prevent blocking other operations in cass-operator.
Which issue(s) this PR fixes:
Fixes #500
Checklist