Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CDC on DSE clusters #478

Merged
merged 13 commits into from
Jan 23, 2023
Merged

Enable CDC on DSE clusters #478

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0856f66
Don't enable MCAC for DSE clusters.
Miles-Garnsey Jan 18, 2023
20d3c40
Update tests and docs.
Miles-Garnsey Jan 18, 2023
d23f8fe
Use new mgmt api agent path.
Miles-Garnsey Jan 18, 2023
48a67d3
Ensure tests + docs refer to current images.
Miles-Garnsey Jan 18, 2023
b20aa16
Add DSE CDC test.
Miles-Garnsey Jan 18, 2023
921cbcd
Changelog.
Miles-Garnsey Jan 18, 2023
3b3fbff
Revert "Add DSE CDC test."
Miles-Garnsey Jan 19, 2023
ce3750e
CDC test for DSE.
Miles-Garnsey Jan 19, 2023
7ad662c
Disable auth for CDC tests.
Miles-Garnsey Jan 19, 2023
ebed106
Revert image coordinates change.
Miles-Garnsey Jan 19, 2023
6487091
Fix rebase related error.
Miles-Garnsey Jan 20, 2023
8a4c616
Fix some errors that came in during rebase.
Miles-Garnsey Jan 20, 2023
9f8537c
Revert kubebuilder version change.
Miles-Garnsey Jan 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
145 changes: 92 additions & 53 deletions .github/workflows/kindIntegTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
- master
- 1.10.x
pull_request:
branches: [ master ]
branches: [master]
jobs:
build_docker_images:
name: Build Docker Images
Expand Down Expand Up @@ -53,9 +53,9 @@ jobs:
strategy:
matrix:
integration_test:
- upgrade_operator # Test is not setup to run against 4.0
- additional_seeds #TODO: Fails against C* 4.0, fix in https://github.com/k8ssandra/cass-operator/issues/459
- scale_down_unbalanced_racks #TODO: Fails against C* 4.0 and DSE 6.8, fix in https://github.com/k8ssandra/cass-operator/issues/459
- upgrade_operator # Test is not setup to run against 4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with these mass-reindents?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation has been pretty inconsistent so I've turned on Trim Trailing Whitespace and Yaml › Format: Enable in vs code, I think everyone should.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also reindented all our CRDs. And those are now being regenerated by the make manifests. So we have 10k line commits doing reindents and I have no idea if anything was changed in them (I just assumed they were re-created after changing the controller-gen version). We can't reindent stuff with these tools if they don't understand what's generated.

- additional_seeds #TODO: Fails against C* 4.0, fix in https://github.com/k8ssandra/cass-operator/issues/459
- scale_down_unbalanced_racks #TODO: Fails against C* 4.0 and DSE 6.8, fix in https://github.com/k8ssandra/cass-operator/issues/459
runs-on: ubuntu-latest
env:
CGO_ENABLED: 0
Expand All @@ -77,57 +77,95 @@ jobs:
name: k8s-logs-${{ matrix.integration_test }}
path: ./build/kubectl_dump

kind_dse_tests:
needs: build_docker_images
strategy:
matrix:
version:
- "6.8.29"
integration_test:
- cdc_successful
include:
- version: 6.8.29
serverImage: datastax/dse-mgmtapi-6_8:6.8.29-jdk8 # DSE 6.8.29
serverType: dse
integration_test: "cdc_successful"
fail-fast: true
runs-on: ubuntu-latest
env:
CGO_ENABLED: 0
M_INTEG_DIR: ${{ matrix.integration_test }}
M_SERVER_VERSION: ${{ matrix.version }}
M_SERVER_IMAGE: ${{ matrix.serverImage }}
M_SERVER_TYPE: ${{ matrix.serverType }}
steps:
- uses: actions/checkout@v3
if: github.event_name == 'pull_request'
with:
ref: ${{ github.event.pull_request.head.sha }}
- uses: actions/checkout@v3
if: github.event_name != 'pull_request'
- uses: ./.github/actions/run-integ-test
with:
integration_test: ${{ matrix.integration_test }}
- name: Archive k8s logs
if: ${{ failure() }}
uses: actions/upload-artifact@v3
with:
name: k8s-logs-smoke_test-${{ matrix.version }}
path: ./build/kubectl_dump

kind_int_tests:
needs: build_docker_images
strategy:
matrix:
version:
- "4.0.7"
- "4.0.7"
integration_test:
# Single worker tests:
- additional_serviceoptions
- additional_volumes
# - delete_node_terminated_container # This does not test any operator behavior
- podspec_simple
# - smoke_test_oss # Converted to test_all_the_things, see below job
# - smoke_test_dse # Converted to test_all_the_things, see below job
# - terminate
# - timeout_prestop_termination
# - upgrade_operator # See kind_311_tests job, Only works for 3.11 right now
- webhook_validation
# Three worker tests:
- canary_upgrade
# - config_change_condition # config_change takes care of testing the same
- cdc_successful # OSS only
# - delete_node_lost_readiness # DSE specific behavior
- host_network
- internode-encryption-generated
#- no_infinite_reconcile # smoke_test_* should take care of this
- node_replace
- nodeport_service
- rolling_restart
- rolling_restart_with_override
# - stop_resume
- superuser-secret-generated
- superuser-secret-provided
- test_bad_config_and_fix
- test_mtls_mgmt_api
# More than 3 workers tests:
- add_racks
#- additional_seeds #TODO: Fails against C* 4.0, fix in https://github.com/k8ssandra/cass-operator/issues/459
- cluster_wide_install
- config_change
- config_secret
# - multi_cluster_management
#- oss_test_all_the_things # This is now the smoke test, see kind_smoke_tests job
- scale_down
# - scale_down_not_enough_space # Not enough stable test
#- scale_down_unbalanced_racks #TODO: Fails against C* 4.0 and DSE, fix in https://github.com/k8ssandra/cass-operator/issues/459
- scale_up
- scale_up_stop_resume
- seed_selection
- config_fql # OSS only
- decommission_dc
# Single worker tests:
- additional_serviceoptions
- additional_volumes
# - delete_node_terminated_container # This does not test any operator behavior
- podspec_simple
# - smoke_test_oss # Converted to test_all_the_things, see below job
# - smoke_test_dse # Converted to test_all_the_things, see below job
# - terminate
# - timeout_prestop_termination
# - upgrade_operator # See kind_311_tests job, Only works for 3.11 right now
- webhook_validation
# Three worker tests:
- canary_upgrade
# - config_change_condition # config_change takes care of testing the same
- cdc_successful # OSS only
# - delete_node_lost_readiness # DSE specific behavior
- host_network
- internode-encryption-generated
#- no_infinite_reconcile # smoke_test_* should take care of this
- node_replace
- nodeport_service
- rolling_restart
- rolling_restart_with_override
# - stop_resume
- superuser-secret-generated
- superuser-secret-provided
- test_bad_config_and_fix
- test_mtls_mgmt_api
# More than 3 workers tests:
- add_racks
#- additional_seeds #TODO: Fails against C* 4.0, fix in https://github.com/k8ssandra/cass-operator/issues/459
- cluster_wide_install
- config_change
- config_secret
# - multi_cluster_management
#- oss_test_all_the_things # This is now the smoke test, see kind_smoke_tests job
- scale_down
# - scale_down_not_enough_space # Not enough stable test
#- scale_down_unbalanced_racks #TODO: Fails against C* 4.0 and DSE, fix in https://github.com/k8ssandra/cass-operator/issues/459
- scale_up
- scale_up_stop_resume
- seed_selection
- config_fql # OSS only
- decommission_dc
# - stop_resume_scale_up # Odd insufficient CPU issues in kind+GHA
# let other tests continue to run
# even if one fails
Expand Down Expand Up @@ -158,11 +196,12 @@ jobs:
strategy:
matrix:
version:
- "3.11.14"
- "4.0.7"
- "6.8.29"
- "3.11.14"
- "4.0.7"
- "6.8.29"
integration_test:
- test_all_the_things
- test_all_the_things
- test_all_the_things
include:
- version: 6.8.29
serverImage: datastax/dse-mgmtapi-6_8:6.8.29-jdk8 # DSE 6.8.29
Expand Down
Loading