Create health condition for degraded status / quorum issues #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsanda
reviewed
Jul 5, 2022
| dcPatch := client.MergeFrom(rc.Datacenter.DeepCopy()) | ||
|
|
||
| if rc.isClusterDegraded() || !rc.isClusterHealthy() { | ||
| updated = rc.setCondition( |
There was a problem hiding this comment.
If the cluster is degraded or unhealthy, should we just requeue?
There was a problem hiding this comment.
We already do that elsewhere, this is just to add the status (as I thought the DBPE-2283 wish was). If we requeue here, then we could never recover from the wrong status.
burmanm
force-pushed
the
create_health_condition
branch
from
6e73b7f to
7e1425a
Compare
jsanda
requested changes
Jul 10, 2022
| @@ -328,6 +328,7 @@ const ( | |||
| DatacenterRollingRestart DatacenterConditionType = "RollingRestart" | |||
| DatacenterValid DatacenterConditionType = "Valid" | |||
| DatacenterDecommission DatacenterConditionType = "Decommission" | |||
| DatacenterHealthy DatacenterConditionType = "Healthy" | |||
There was a problem hiding this comment.
Can you add some comments explaining this?
jsanda
approved these changes
Jul 12, 2022
burmanm
added a commit
that referenced
this pull request
Jul 18, 2022
* Add DatacenterHealth condition * Modify the DatacenterHealth status update to occur on the starting nodes part * Fix rebase * Add description to DatacenterHealthy * Add lint to the Makefile, remove unused isDegraded (cherry picked from commit b498b7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In case CassandraDatacenter is under some operation that degrades the cluster or QUORUM health check fails, update Condition on the Status to indicate this. This is to make user aware that certain other operations are not going to be successful.
Which issue(s) this PR fixes:
Fixes #376
Checklist