Fix: label values not validated (#355) #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
previously requested changes
Jun 5, 2022
burmanm
reviewed
Jun 8, 2022
5 tasks
adejanovski
requested changes
Jun 10, 2022
There was a problem hiding this comment.
A few changes, and you'll also need to clean this label.
And I have a few tests in my PR that you can cherry pick.
|
@burmanm @emerkle826 @adejanovski In the latest push: Added support for handling the label |
Update CHANGELOG.md Co-authored-by: Alexander Dejanovski <[email protected]> Support for CreatedByLabelValue; clean labels in api Smoke test updates
adejanovski
approved these changes
Jun 13, 2022
Co-authored-by: Alexander Dejanovski <[email protected]>
Co-authored-by: Alexander Dejanovski <[email protected]>
|
@adejanovski thanks for the quick review and keeping the comments accurate to the |
|
Label values validated in recent changes. |
|
@jeffbanks, can we move forward and merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Provides cleaning of the cluster name being used for part of overall label value. The cluster name can contain illegal characters not allowed for label values.
Which issue(s) this PR fixes:
Fixes #335
Checklist