Add missing requeue to Datacenter decommission #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
changed the title
|
@burmanm can you please create an issue for this? |
jsanda
reviewed
Apr 20, 2022
| @@ -70,6 +70,8 @@ func (rc *ReconciliationContext) ProcessDeletion() result.ReconcileResult { | |||
| // Exiting to let other parts of the process take care of the decommission | |||
| return result.Continue() | |||
| } | |||
| // How could we have pods if we've decommissioned everything? | |||
| return result.RequeueSoon(5) | |||
There was a problem hiding this comment.
Are you adding the requeue here to handle the scenario where len(dcs) == 1?
There was a problem hiding this comment.
Why would we requeue in that case? If len(dcs) == 1, we go and delete the DC.
There was a problem hiding this comment.
It's not obvious to me why the need for the requeue here. Can you explain?
jsanda
approved these changes
Apr 21, 2022
burmanm
added a commit
that referenced
this pull request
May 12, 2022
* Add requeue if we still have pods although decommission has succeeded * CHANGELOG (cherry picked from commit addd528)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Decommissioning datacenter is missing a requeue after scaling down is done, but the pods haven't been removed yet. This can cause the operator to remove PVCs before Cassandra has properly shutdown (it has 30s wait after decommission).
Which issue(s) this PR fixes:
Fixes #323
Checklist