Adding AdditionalLabels

[piclemx]

What this PR does:
Adding the possibility to people to add Labels and the all objects that will be created by the operator.

Which issue(s) this PR fixes:
Fixes #235

Checklist

• Changes manually tested
• Automated Tests added/updated
• Documentation added/updated
• CHANGELOG.md updated (not required for documentation PRs)
• CLA Signed: DataStax CLA

[jsanda]

You're off to a good start. There are some other objects that the operator like the superuser secret and endpoints for the additional seeds service. There might be more, but those are the ones I know of immediately.

Are you going to add corresponding functionality for annotations?

[piclemx]

You're off to a good start. There are some other objects that the operator like the superuser secret and endpoints for the additional seeds service. There might be more, but those are the ones I know of immediately.

Are you going to add corresponding functionality for annotations?

I think for now I will only add the labels for the first step. I can do the annotations later if you want? If you want both of them now I can also work on getting both.

[piclemx]

I will be adding the missing test tomorrow.

[piclemx]

@jsanda @burmanm could you do another round of review?

For the annotation, do you mind I do that in another merge request?

[piclemx]

@jsanda @burmanm do you still have sometime to review this one 🥺

[jsanda]

Last week was a really short week for me due to the Thanksgiving holiday, and I just didn't have time to get back to it. I will do another review today or tomorrow.

[jsanda]

My apologies for the delayed review. The changes look good. There is another place you need to update for the default super user secret. See here.

[piclemx]

My apologies for the delayed review. The changes look good. There is another place you need to update for the default super user secret. See here.

Does it make sense to use the AddOperatorLabels there also?

You don't need to apologies @jsanda ;)

[jsanda]

Does it make sense to use the AddOperatorLabels there also?

yeah, I think so

[piclemx]

Does it make sense to use the AddOperatorLabels there also?

yeah, I think so

Done

[jsanda]

Thanks for adding the changes for the superuser secret. Pending the test run, I think it is good to go :)

[piclemx]

Nice thank you ;)

[jsanda]

Thanks!