Allow dns lookup by pod name for all pods #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This type of change requires regenerating the client / sdk. So |
|
@burmanm are you sure? Those commands produced no changes when ran |
jsanda
approved these changes
May 3, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some background for this change:
The purpose of the
ServiceNamefield of a StatefulSet is to specify the name of the service under which DNS subdomain records are created for each pod: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#stable-network-idThe operator makes two services for dse pods, one with
PublishNotReadyAddressesset totrueand one with it set tofalse.Setting the
ServiceNameto the service which hasPublishNotReadyAddressesset totrueallows dns lookups for pods that are not ready yet.This can be useful in a number of scenarios, one of which is having the pods on an overlay network with stable IPs, where pod to pod communication happens via dns names: https://www.datastax.com/blog/2021/05/how-connect-stateful-workloads-across-kubernetes-clusters