Do not try to update the ServiceName in existing StatefulSets #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsanda
approved these changes
May 26, 2021
|
config_secret passed when ran separately, so just flaky in the GHA. |
|
As well as UpgradeTest in k8ssandra |
burmanm
added a commit
that referenced
this pull request
May 26, 2021
* Do not try to update the ServiceName in existing StatefulSets * Fix existing unit tests * Add small test to verify the ServiceName is not modified by the newStatefulSetForCassandraDatacenter (cherry picked from commit fa0b5e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
If existing StatefulSet is modified, do not try to update the ServiceName.
Which issue(s) this PR fixes:
Fixes #103
Checklist