-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8ssandra repository move #1
Conversation
Update go.sum Fix code generator Modify build-push-action to use file and tag :latest Rename kind cluster in test to kind and update CODEOWNERS Build and push operator to kind installation, add helm Rename storageClassName to standard (newer kind default)
tests. Replace k8s:reloadOperator with command line parameters and buildx Add setup buildx Use buildx for all builds, move to Go 1.16 Add --load for buildx
* Add new image for system-logger that is faster to shutdown * Remove docker build id from integ test * Add back override of custom system logger image * Change default imagePullPolicy for system-logger
@@ -3,80 +3,76 @@ on: | |||
push: | |||
branches: | |||
- master | |||
- "1.4.x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove the 1.4.x and 1.5.x branches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing old stuff we're not targeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that those branches still need to be maintained for customer support. I suppose that they could be maintained in the repo in the DataStax org. Who is going to be handling bug fixes for customer support. I would expect over time that it will be us. If that is the case, does it make sense to keep them?
@bradfordcp can you chime in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't that the deal that old versions are going to stay in the datastax/cass-operator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add back or update needed functionality in follow up PRs. I don't want to hold up merging on this as it currently does not impact k8ssandra.
|
||
############################################################# | ||
|
||
FROM ${BASE_OS} AS builder-ubi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we building the UBI images elsewhere? If not then I am pretty sure we still need this. It is needed for OpenShift integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is our Openshift strategy? As far as I read from the cass-operator tickets, it hasn't been working for a while:
https://github.com/datastax/cass-operator/issues/266
So not in 4.5, not in 4.6, probably not in 4.7 .. and in k8ssandra we haven't tested anything against Openshift. Also, this k8ssandra/cass-operator path is not supported in the container catalog (only datastax/cass-operator is).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradfordcp can you chime in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add back or update needed functionality in follow up PRs. I don't want to hold up merging on this as it currently does not impact k8ssandra.
* Fossa Integration * Add fossa configuration file generated with `fossa init` * Add GH action to trigger tooling on pushes to master and on releases * Add temporary hook for pull_requests for testing * Split out and update workflows. * Fix typo * Restructure yaml * Fix typo * Testing * Disable other workflows for testing * Restructure * File will be autogenerated each run. * Debugging * More debug * Remove debug code * Debug release workflow * Switch to outputs from env variables * TEsting * More debug * Last test, getting close. * Final changes. * Revert test changes to other workflows * K8 ssand 488 fossa integration (#1) * Fossa Integration * Add fossa configuration file generated with `fossa init` * Add GH action to trigger tooling on pushes to master and on releases * Add temporary hook for pull_requests for testing * Split out and update workflows. * Fix typo * Restructure yaml * Fix typo * Testing * Disable other workflows for testing * Restructure * File will be autogenerated each run. * Debugging * More debug * Remove debug code * Debug release workflow * Switch to outputs from env variables * TEsting * More debug * Last test, getting close. * Final changes. * Revert test changes to other workflows * Remove testing on-push * K8 ssand 488 fossa integration (#2) * Fossa Integration * Add fossa configuration file generated with `fossa init` * Add GH action to trigger tooling on pushes to master and on releases * Add temporary hook for pull_requests for testing * Split out and update workflows. * Fix typo * Restructure yaml * Fix typo * Testing * Disable other workflows for testing * Restructure * File will be autogenerated each run. * Debugging * More debug * Remove debug code * Debug release workflow * Switch to outputs from env variables * TEsting * More debug * Last test, getting close. * Final changes. * Revert test changes to other workflows * Remove testing on-push * Fossa Integration * Add fossa configuration file generated with `fossa init` * Add GH action to trigger tooling on pushes to master and on releases * Add temporary hook for pull_requests for testing * Split out and update workflows. * Fix typo * Restructure yaml * Fix typo * Testing * Disable other workflows for testing * Restructure * Debugging * More debug * Remove debug code * Debug release workflow * Switch to outputs from env variables * TEsting * More debug * Last test, getting close. * Final changes. * Revert test changes to other workflows * Re-enable scanning on PRs * Remove the release check workflow * Switch to only on push to better fit the model Fossa exposes. * Update readme to include link to public scanning report. * Update changelog * Include the fossa configuration file in source control instead of generation. * limit checks to changes in code paths * Modify so that workflow is triggered on all pushes to master - this keeps the commits in sync between GH and Fossa's reports.
Add necessary changes for the new cass-operator repository to make it fit the k8ssandra structure: