Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the same README document of whereabouts,the broadcast address will not be included while calculating ip addresses given in the range by user.
If for example the
range
is set to192.168.2.225/28
, this will allocate IP addresses in the range excluding the first network address and the last broadcast address.The above is correct.
But at the start of the document, an example given as below looks incorrect.
Whereabouts takes an address range, like
192.168.2.0/24
in CIDR notation, and will assign IP addresses within that range. In this case, it will assign IP addresses from192.168.2.1
to192.168.2.255
.192.168.2.255
is broadcast address, instead it should range from
192.168.2.1to
192.168.2.254`.