Moved IP Reconciler code into IP Control Loop

[nicklesimba]

This commit removes the IP Reconciler as a separate binary, and also removes the cronjob that launched it.

Instead, the code now invokes the reconciler code at a user configurable interval (once per day default).

As part of these changes, the code has also been reorganized with more clear file names etc.

[maiqueb]

Nice. Mostly I just have nits.

[maiqueb]

You'll need to move the shutdown of the work-queue to the main function - it must run after the stopChannel is caught.

I would simply defer it within the main. For that, you'll need to add a receiver function to the pod controller that shuts down the queue.

[maiqueb]

You now registering the fail handler, and attempting to run the specs twice in the same pkg.

You cannot do that. Remove the following lines from the pkg/reconciler/suite_test.go file.

func TestAPIs(t *testing.T) {
	RegisterFailHandler(Fail)
	RunSpecsWithDefaultAndCustomReporters(t,
		"Whereabouts IP reconciler Suite",
		[]Reporter{})
}

Or, better yet, merge the pkg/reconciler/ip_test.go and pkg/reconciler/iploop_test.go - each should have a different Describe block.

This would address your current unit test error.

[coveralls]

Pull Request Test Coverage Report for Build 2630891680

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 27 of 61 (44.26%) changed or added relevant lines in 2 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+5.3%) to 59.227%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/config/config.go	27	34	79.41%
pkg/reconciler/ip.go	0	27	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/config/config.go	2	56.18%

Totals
Change from base Build 2618291237:	5.3%
Covered Lines:	950
Relevant Lines:	1604

---

💛 - Coveralls

[dougbtv]

I'm ready to move forward on this change. Thanks for the hard work and all the follow up to get it in order. Well done.

Let's just squash the commits. Keep one commit for the vendor changes, and one more commit for the rest of the changes 👍

[dougbtv]

LGTM! 💯