Change default controller ID to 1 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kernel 5.10 or newer added support for encoding controler ID in the physical port name of the representor in cases where external controller exists (Smart-NICs). This controller ID is by default 1 and not 0. Signed-off-by: Adrian Chiris <[email protected]>
|
This commit introduced the change to devlink port: torvalds/linux@66b1708 This code determines the controller number: https://github.com/torvalds/linux/blob/9d31d2338950293ec19d9b095fbaa9030899dcb4/drivers/net/ethernet/mellanox/mlx5/core/esw/devlink_port.c#L42 when working with upstream kernel it seems the controller number is 1 and not 0 |
|
lgtm |
moshe010
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernel 5.10 or newer added support for encoding controler ID in the
physical port name of the representor in cases where external
controller exists (Smart-NICs).
This controller ID is by default 1 and not 0.
Signed-off-by: Adrian Chiris [email protected]