Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Stick with Go 1.17 #277

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Apr 6, 2022

As the Makefile uses deprecated Go features, GH actions should use a fixed 1.17.* version of Golang.
This is intended as a temporary fix for #231

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

As the Makefile uses deprecated Go features, GH actions
should use a fixed 1.17.* version of Golang.

Signed-off-by: Andrea Panattoni <[email protected]>
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing CI

@adrianchiris
Copy link
Collaborator

lgtm

@adrianchiris
Copy link
Collaborator

@SchSeba @zshi-redhat PATL this is needed for CI to pass

@SchSeba
Copy link
Collaborator

SchSeba commented Apr 13, 2022

/lgtm

@github-actions github-actions bot added the lgtm label Apr 13, 2022
@SchSeba SchSeba merged commit 162c2b2 into k8snetworkplumbingwg:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants