remove vendoring, use Go modules by default #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @jaypipes , can you please rebase and run |
|
@zeeke np, all done. |
|
The linters are not happy can you please take a look? |
Removes the vendor/ directory and all vestiges of life before Go modules. Also updates pkg/utils/testing.go to properly account for non-RHEL systems, which typically store the pci.ids file at /usr/share/misc/pci.ids instead of /usr/share/hwdata/pci.ids. Issue k8snetworkplumbingwg#544 Signed-off-by: Jay Pipes <[email protected]>
|
@SchSeba apologies for the long delay in getting back to this! Rebased from main which should fix any linter failures. |
adrianchiris
approved these changes
Jun 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the vendor/ directory and all vestiges of life before Go modules.
Also updates pkg/utils/testing.go to properly account for non-RHEL
systems, which typically store the pci.ids file at
/usr/share/misc/pci.ids instead of /usr/share/hwdata/pci.ids.
Addresses golint warnings around grpc.DialContext being deprecated by
replacing calls with grpc.NewClient.
Issue #544