Makefile: dont't run "test" as part of default "all" make target #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unit tests require CAP_NET_ADMIN permissions, so commonly they fail
in a developer environment for valid reasons.
Having the "test" target part of the default make target ("all") will
fail in such an environment, which is inconvenient.
Running unit tests should be a separate make target. To run tests,
explicitly run `make test`.
Fixes: f2dbb73 ('Makefile refactor')
Pull Request Test Coverage Report for Build 10196801226Details
💛 - Coveralls |
|
This applies in a similar way to k8snetworkplumbingwg/sriov-network-device-plugin#579 CC: @adrianchiris |
adrianchiris
approved these changes
Aug 12, 2024
Eoghan1232
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests require CAP_NET_ADMIN permissions, so commonly they fail in a developer environment for valid reasons.
Having the "test" target part of the default make target ("all") will fail in such an environment, which is inconvenient.
Running unit tests should be a separate make target. To run tests, explicitly run
make test.Fixes: f2dbb73 ('Makefile refactor')
Follow-up to #305 (comment)