Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Making workflows not run on forks. #294

Conversation

adilGhaffarDev
Copy link
Contributor

This PR is making sure that github workflows only run on upstream repo and not on forks.

@coveralls
Copy link

coveralls commented Mar 11, 2024

Pull Request Test Coverage Report for Build 8966234367

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 47.514%

Totals Coverage Status
Change from base Build 8835333415: 0.0%
Covered Lines: 602
Relevant Lines: 1267

💛 - Coveralls

Signed-off-by: muhammad adil ghaffar <[email protected]>
@adilGhaffarDev
Copy link
Contributor Author

@Eoghan1232 @SchSeba @adrianchiris can we merge this one?

@zeeke
Copy link
Member

zeeke commented May 15, 2024

similar PR didn't work on sriov-device-plugin
https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/actions/runs/9091929799

/hold

@adrianchiris
Copy link
Contributor

adrianchiris commented Jul 31, 2024

a few comments on why we might not want this:

  1. you can disable actions on fork
  2. actions run against master and v* tags, on a normal dev flow you create some branch like "fix-something" then push to it. actions should not run on it.
  3. you may want to develop actions on your fork so in this case its beneficial for them to run on the fork for testing.

what is the reason to have this change ?

@SchSeba
Copy link
Collaborator

SchSeba commented Aug 20, 2024

+1 from my side to not add this.
you can just disable github actions on your fork.
also it introduce an issue on the device plugin so if possible I will not like to add more complexity to our release pipeline :)

@adrianchiris
Copy link
Contributor

closing this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants