Add support for s390x architecture in GitHub Actions workflows. #337
Conversation
Updated GitHub Actions workflows to include linux/s390x in BUILD_PLATFORMS. Modified hack/install-go.sh to dynamically select the appropriate Go tarball based on the system's architecture(amd64, arm64, or others), allowing better support for multi-architecture environments. Signed-off-by: Ashok Pariya <[email protected]>
kubevirt-bot
added
release-note-none
|
Hi @ashokpariya0. Thanks for your PR. I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubevirt-bot
added
the
needs-ok-to-test
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| destination=$1 | |||
| version=$(curl -s https://go.dev/dl/?mode=json | jq -r ".[0].version") | |||
| tarball=$version.linux-amd64.tar.gz | |||
| arch=$(uname -m | sed 's/x86_64/amd64/;s/aarch64/arm64/') | |||
There was a problem hiding this comment.
Is that required? IIUC the binaries for all platforms are cross-compiled on amd64?
There was a problem hiding this comment.
Yes.that's correct.
There was a problem hiding this comment.
If you're asking why we use the sed command, here's the explanation:
The terms "x86_64" and "amd64" refer to the same architecture. However, the uname -m command returns "x86_64" to describe this architecture. On the other hand, the Go programming language uses the term "amd64" for this architecture. Therefore, to ensure consistency with Go and cross-compilation setups, we use the sed command to rename "x86_64" to "amd64".
There was a problem hiding this comment.
Yes, I got that. Just asking if we need this change or if we can continue to cross compile on amd64.
There was a problem hiding this comment.
we need this change to build on s390x or other platforms.
|
/ok-to-test |
|
@0xFelix: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@oshoval Please mark this as ok-to-test |
|
/retest |
|
@0xFelix: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Bot does not like me :( |
|
Dont take it personally, he doesn't know you yet, we like you very much :) |
|
/ok-to-test |
kubevirt-bot
added
ok-to-test
There was a problem hiding this comment.
/lgtm
/approve
Thanks @ashokpariya0 for posting this, and @oshoval + @0xFelix for the review.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix, ashokpariya0, oshoval, phoracek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Updated GitHub Actions workflows to include linux/s390x in BUILD_PLATFORMS. Modified hack/install-go.sh to dynamically select the appropriate Go tarball based on the system's architecture(amd64, arm64, or others), allowing better support for multi-architecture environments.
What this PR does / why we need it:
these changes enhances GitHub Actions workflows by adding linux/s390x to BUILD_PLATFORMS.
also updates hack/install-go.sh to automatically select the correct Go tarball based on the system architecture (amd64, arm64, or others), improving support for multi-architecture environments.
Special notes for your reviewer:
Release note: