Go module support #12
Conversation
| @@ -9,7 +9,7 @@ import ( | |||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
| "k8s.io/client-go/tools/clientcmd" | |||
|
|
|||
| clientset "github.com/k8snetworkplumbingwg/network-attachment-definition-client/pkg/client/clientset/versioned" | |||
| clientset "github.com/K8sNetworkPlumbingWG/network-attachment-definition-client/pkg/client/clientset/versioned" | |||
There was a problem hiding this comment.
What does this change imply to dep users? We faced an issue with dep being unable to handle upper-case letters https://github.com/K8sNetworkPlumbingWG/network-attachment-definition-client#networkattachmentdefinition-crd-client.
Just making sure this change won't break existing users.
There was a problem hiding this comment.
Currently this PR could be succeed to build command with go-module.
The build may be fail if you use non go-module build environment. Golang now makes go module default, hence it should be okey.
In the future, we should consider the change of github group name (from K8sNetworkPlumbingWG, mixed-case to others).
There was a problem hiding this comment.
As far as I looks dep, golang/dep#1079 may fix the issue, I guess.
And there's some github projects that fix same stuff:
https://github.com/hashicorp/consul-template/pull/1139/files
There was a problem hiding this comment.
I see. Fair enough. Thanks Tomo.
s1061123
force-pushed
the
dev/go-modules
branch
5 times, most recently
from
fca8210 to
1d3ea6b
Compare
s1061123
force-pushed
the
dev/go-modules
branch
from
1d3ea6b to
381919f
Compare
No description provided.