controller: update status via the net-attach-def-client lib #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiqueb
force-pushed
the
update-status-via-net-attach-def-client-lib
branch
2 times, most recently
from
9db5715 to
57a60f4
Compare
maiqueb
force-pushed
the
update-status-via-net-attach-def-client-lib
branch
2 times, most recently
from
ab14f8d to
e2639e6
Compare
Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
update-status-via-net-attach-def-client-lib
branch
from
e2639e6 to
d9bad91
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Until we have a level driven controller, the embedded retry-on-conflict embedded in the library might come in handy.
The controller must be refactored to compare the network selection elements with whatever is on the status annotation, rather than comparing old & new network selection elements.
Finally, this refactor should evaluate if we want to have a separate annotation for dynamic attachments. This should be pitched to the k8snetworkplumberswg.
Special notes for your reviewer (optional):
Depends-on: #83