Handle old pods without network selection elements #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Duarte Barroso <[email protected]>
phoracek
reviewed
Oct 26, 2022
This commit fixes the hotplug scenario where the running pod does **not** feature any attachments other than the default cluster network. Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
handle-old-pods-without-network-selection-elements
branch
from
f0267bd to
0acf8f5
Compare
maiqueb
deleted the
handle-old-pods-without-network-selection-elements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allows hot-plugging interfaces into a pod without any
network-selection-elements.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #43
Special notes for your reviewer (optional):