Send desired IP / MAC address to multus server #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiqueb
changed the title
The network attachment definition returned does **not** have IPAM configured; as such, we should rename the variable accordingly. Which we did. Signed-off-by: Miguel Duarte Barroso <[email protected]>
Simplify the `AddNetworkToPod` calls by passing directly the `NetworkSelectionElements`. This way, we can also set directly the IP / MAC without making a mess of the function signature. Signed-off-by: Miguel Duarte Barroso <[email protected]>
This attribute was hard-coded, which was error prone, since the function that generates this net-attach-def does receive a network name parameter. Signed-off-by: Miguel Duarte Barroso <[email protected]>
This test explicitly requests both the IP address (which requires IPAM) and the MAC address (which requires the `tuning` plugin) for the pod. Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
send-desired-iface-data-to-multus-server
branch
from
2db331c to
9de0ac3
Compare
phoracek
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds tests asserting runtime configuration (pod / MAC addresses) can be requested for the delegate being added.
It also adds an e2e test proving that removing an interface with runtime configuration is possible.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #42
Special notes for your reviewer (optional):