Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update dependencies #182

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

0xFelix
Copy link
Contributor

@0xFelix 0xFelix commented Oct 30, 2023

What this PR does / why we need it:

Updated modules golang.org/x/* and github.com/emicklei/go-restful to the latest versions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer (optional):

@0xFelix 0xFelix requested a review from maiqueb as a code owner October 30, 2023 10:55
@maiqueb
Copy link
Collaborator

maiqueb commented Oct 30, 2023

Why is this useful ?

What bumps does this unlock ?

Why shouldn't we rely on dependabot instead ?

@0xFelix ^

@0xFelix
Copy link
Contributor Author

0xFelix commented Oct 30, 2023

We can stick to dependabot, but it didn't catch neither github.com/emicklei/go-restful nor golang.org/x/net. This PR updates them + all other golang.org/x/* dependencies.

@oshoval
Copy link
Member

oshoval commented Oct 31, 2023

Imo we should be ok-to-test
the same effort is done on all the other repos, and is on priority right now
Thanks

Updated modules golang.org/x/* and github.com/emicklei/go-restful
to the latest versions.

Signed-off-by: Felix Matouschek <[email protected]>
@maiqueb maiqueb merged commit fcc5f6b into k8snetworkplumbingwg:main Nov 2, 2023
1 of 2 checks passed
@maiqueb
Copy link
Collaborator

maiqueb commented Nov 2, 2023

Chosen to ignore the failed e2e test since our e2e tests are notoriously flaky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants