Fix each ds instance listens to events on its node #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiqueb
force-pushed
the
fix-each-ds-instance-listens-to-events-on-its-node
branch
from
2510eef to
af6ebed
Compare
phoracek
reviewed
Sep 16, 2022
maiqueb
force-pushed
the
fix-each-ds-instance-listens-to-events-on-its-node
branch
from
af6ebed to
5a48d5a
Compare
phoracek
approved these changes
Sep 16, 2022
With this environment variable, the controllers are able to only watch events for pods scheduled on their node. Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
fix-each-ds-instance-listens-to-events-on-its-node
branch
from
5a48d5a to
21c561e
Compare
maiqueb
deleted the
fix-each-ds-instance-listens-to-events-on-its-node
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-on: #16
This PR ensures the hostname of the controller pods is the name of the nodes where they are scheduled.
This enables the controller to listen exclusively to events on the node where it is deployed, and thus request delegates from multus for pods scheduled on the node it manages.