Fix default multus socket path #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `config` pkg code was updated to feature a different key name, and unfortunately the template / deployment manifest were not updated. The right key can be found in [0]. [0] - https://github.com/maiqueb/multus-dynamic-networks-controller/blob/245d20966cad3c6a8c09e80bc17c2adb31312cfa/pkg/config/types.go#L28 Signed-off-by: Miguel Duarte Barroso <[email protected]>
The multus socket by default is named `multus.sock` as can be seen in [0]. [0] - https://github.com/k8snetworkplumbingwg/multus-cni/blob/549808011920e6c6f0dd4b78a75250d865e7c1c9/pkg/server/api/socket.go#L23 Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
fix-default-multus-socket-path
branch
from
a3c74a8 to
6845440
Compare
phoracek
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13