ci, build: use the correct dockerfile image #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must use the dockerfile for the thick plugin version. Up to now this was not an issue since the thin version featured the `cp` command, which is used on the thick-plugin initcontainer. Now that the thin plugin version daemonset spec was updated (it no longer features the `cp` command), the thick plugin version init container fails to perform its task. Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
fix-multus-e2e-test-build-thick-plugin-dockerfile
branch
from
bda12d2 to
d6a66f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We must use the dockerfile for the thick plugin version - we were using the multus setup script default, which is to use the thin version.
Up to now this was not an issue since the thin version featured the
cpcommand, which is used on the thick-plugin initcontainer. Now that the thin plugin version daemonset spec was updated (it no longer features thecpcommand), the thick plugin version init container fails to perform its task.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #134
Special notes for your reviewer (optional):