Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e bump timeouts #128

Merged
merged 2 commits into from
Mar 27, 2023
Merged

E2e bump timeouts #128

merged 2 commits into from
Mar 27, 2023

Conversation

maiqueb
Copy link
Collaborator

@maiqueb maiqueb commented Mar 14, 2023

What this PR does / why we need it:
Sometimes 2 seconds can be not enough on CI to reconcile the attachments
for a pod when a pod does not feature the interface names; also, this timeout
is also used for a Consistently clause, where 2 seconds is also too little.

Thus, let's give it some more time.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #124

Special notes for your reviewer (optional):

maiqueb added 2 commits March 14, 2023 09:17
Sometimes 2 seconds can be not enough on CI to reconcile the attachments
for a pod; also, this timeout is also used for a `Consistently` clause,
where 2 seconds is also too little.

Thus, let's give it some more time.

Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
@maiqueb maiqueb requested a review from RamLavi March 14, 2023 08:26
@qinqon
Copy link
Member

qinqon commented Mar 27, 2023

/lgtm
/approve

@maiqueb maiqueb merged commit c29c24a into main Mar 27, 2023
@maiqueb maiqueb deleted the e2e-bump-timeouts branch March 27, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants