build, ci, test: bump to golang 1.19 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
update-golang-1.19
branch
2 times, most recently
from
91ff0c5 to
2b712d8
Compare
|
@oshoval FYI Plan is to merge once go1.18 goes EOL. |
maiqueb
commented
Jan 5, 2023
|
|
||
| - name: Build | ||
| run: time make build | ||
|
|
||
| - name: Linters | ||
| uses: golangci/golangci-lint-action@v3 | ||
| with: | ||
| version: v1.47.3 | ||
| version: v1.48.0 |
There was a problem hiding this comment.
first version w/ golang 1.19 support.
kmabda
approved these changes
Jan 9, 2023
maiqueb
force-pushed
the
update-golang-1.19
branch
from
2b712d8 to
99629bc
Compare
Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
update-golang-1.19
branch
from
99629bc to
d7954c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miguel Duarte Barroso [email protected]
What this PR does / why we need it:
This PR bumps the golang version to 1.19.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer (optional):