Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support go 1.22 and 1.23 build to fix CVE #1355

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

smoshiur1237
Copy link
Contributor

This PR will address a CVE, reported in #1354

@juliusmh
Copy link

At this point, we could jump (or at least test) 1.23 as well.

@smoshiur1237
Copy link
Contributor Author

@juliusmh I can add support for 1.23 .

@smoshiur1237
Copy link
Contributor Author

@juliusmh I have added support for both 1.22 and 1.23.

@smoshiur1237 smoshiur1237 changed the title Support go 1.22 build to fix CVE Support go 1.22 and 1.23 build to fix CVE Nov 22, 2024
@kashifest
Copy link

@s1061123 can we merge this patch?

@smoshiur1237
Copy link
Contributor Author

@dougbtv @s1061123 @juliusmh would you please check or review to prioritize this patch and create a new release. The fix for CVE is critical and would appreciate if you please take it in.

@juliusmh
Copy link

juliusmh commented Dec 5, 2024

@smoshiur1237 I have no authority in this repository.

@s1061123
Copy link
Member

s1061123 commented Dec 5, 2024

Could you please care this one?

go-version: 1.19.x

@coveralls
Copy link

coveralls commented Dec 5, 2024

Coverage Status

coverage: 56.454%. remained the same
when pulling ddbcd2c on Nordix:fix-cve-moshiur
into 781ecda on k8snetworkplumbingwg:master.

@smoshiur1237
Copy link
Contributor Author

Could you please care this one?

go-version: 1.19.x

do I change it to 1.22 or 1.23?

@smoshiur1237 smoshiur1237 requested a review from s1061123 December 5, 2024 14:54
Signed-off-by: smoshiur1237 <[email protected]>
@smoshiur1237
Copy link
Contributor Author

@dougbtv @s1061123 Thanks for your review. I have addressed them and pushed the changes. Please let me know if it is ok?

@smoshiur1237 smoshiur1237 requested a review from dougbtv December 5, 2024 15:06
@smoshiur1237
Copy link
Contributor Author

smoshiur1237 commented Dec 5, 2024

Could you please care this one?

go-version: 1.19.x

do I change it to 1.22 or 1.23?

I asked @dougbtv and he agrees to keep it for 1.22 as minimum version support stays for 1.22

@dougbtv dougbtv merged commit 4fc16b3 into k8snetworkplumbingwg:master Dec 6, 2024
24 checks passed
@smoshiur1237
Copy link
Contributor Author

Thanks @dougbtv and @s1061123 for review and take this in. would you please tag it as v4.1.4 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants