[WIP] Ensure deviceID is set when a resource is requested #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a NAD has the resourceName annotation set, then it means that the subsequent CNI calls should provide the deviceID for that particular resource. Previously, we were doing best effort to get the deviceID from kubelet. With this patch, we guarantee the deviceID will be passed in the CNI call and fail if we can't find any deviceID. Signed-off-by: Vasilis Remmas <[email protected]>
vasrem
force-pushed
the
bugfix/ensure-resource-is-passed
branch
from
c4f6991 to
06f0fd8
Compare
vasrem
changed the title
dougbtv
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Let's make sure this functionality is described in: https://github.com/k8snetworkplumbingwg/multus-cni/blob/master/docs/how-to-use.md?plain=1#L677
|
Closing this PR as this bugfix breaks the DRA integration. To support the DRA integration, we have to switch the e2e test to use On a similar note, DRA API for 1.31 Kubernetes will change, so the plan is to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a NAD has the resourceName annotation set, then it means that the subsequent CNI calls should provide the deviceID for that particular resource.
Previously, we were doing best effort to get the deviceID from kubelet. With this patch, we guarantee the deviceID will be passed in the CNI call and fail if we can't find any deviceID.