pass through the pod annotations when multus receives them

[toelke]

See kubernetes/kubernetes#69882 (comment) and #1116

Passing the annotations seems not to be a standardized behaviour, but it is very useful nontheless.

[s1061123]

I'm not clear that io.kubernetes.cri.pod-annotations comes from and use-case yet. Could you please clarify that, including why the annotation, io.kubernetes.cri.pod-annotations, should be default (to all platform).

[toelke]

This comment is a good summary.

My use case is that a custom CNI plugin needs some extra information to configure the networking of a Pod that I would like to pass as an annotation on the Pod; containerd can already be configured to pass this annotation to CNI plugins, this patch enables multus to receive it.

[dougbtv]

Tomo's looking into the possibility of checking this out with capability args in the meanwhile, and we'll circle back to it to make sure it's necessary.

[aojea]

Tomo's looking into the possibility of checking this out with capability args in the meanwhile, and we'll circle back to it to make sure it's necessary.

@dougbtv @s1061123 I think that this refers to the fact that you don't have to go to the apiserver to fetch the labels and the annotations of the pod if you set this option in containerd and crio kubernetes/kubernetes#69882 (comment), as those values will be available in the CNI ADD request
@MikeZappa87

Basically you can save this API call and get it from the capabilities

multus-cni/pkg/k8sclient/k8sclient.go

Lines 407 to 421 in 53a68c3

	func GetPodNetwork(pod *v1.Pod) ([]*types.NetworkSelectionElement, error) {
	logging.Debugf("GetPodNetwork: %v", pod)
	netAnnot := pod.Annotations[networkAttachmentAnnot]
	defaultNamespace := pod.ObjectMeta.Namespace
	if len(netAnnot) == 0 {
	return nil, &NoK8sNetworkError{"no kubernetes network found"}
	}
	networks, err := parsePodNetworkAnnotation(netAnnot, defaultNamespace)
	if err != nil {
	return nil, err
	}
	return networks, nil

[AJMansfield]

This would be a useful feature for my own use-case -- to pass node affinity/taint information concerning particular network attachments onto pods that use them.

[bgaussen]

Hi, this feature would help our CNI to get some pod annotations directly and avoid implementing token management for it to access api-server...

[github-actions]

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[toelke]

I still think this is useful.

[toelke]

/remove-lifecycle stale