Deployments: Add watch permission to thick example #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ClusterRole was missing the watch permission on pods, which resulted in Multus throwing this error message every few seconds: Failed to watch *v1.Pod: unknown (get pods)
|
Based on 50c0357, I'm guessing you might also need to update |
maiqueb
suggested changes
Nov 6, 2023
There was a problem hiding this comment.
Good catch.
Please do what @sdwilsh is saying in #1171 (comment) and also add the watch permission to the e2e test template manifest.
|
Thank you for the PR, @J0n4t4n ! Merged. |
LionelJouin
added a commit
to LionelJouin/multus-cni
that referenced
this pull request
Jan 11, 2024
As described in k8snetworkplumbingwg#1171, the watch function is required in the clusterrole for the thick Multus version, otherwise "Failed to watch *v1.Pod" would be returned.
s1061123
pushed a commit
that referenced
this pull request
Jan 18, 2024
As described in #1171, the watch function is required in the clusterrole for the thick Multus version, otherwise "Failed to watch *v1.Pod" would be returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ClusterRole was missing the watch permission on pods, which resulted in Multus throwing this error message every few seconds:
I am unsure if this permission is also needed for the other 2 example yamls, so I've just added it to the one I tested for the moment.