tests: wait for new managers to become available #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoracek
force-pushed
the
wait_for_new_managers_to_take_over
branch
from
24b8dc9 to
48f8465
Compare
In the current code, setRange and deleteLeaderManager functions are not waiting for the old pods to disappear and new ones to become available. Due to that, tests using this functions don't have any webhook available or worse, they are being served by the old one. This issue was not exposed due to Eventually we have around all the Create calls. Signed-off-by: Petr Horacek <[email protected]>
phoracek
force-pushed
the
wait_for_new_managers_to_take_over
branch
from
48f8465 to
f9da8fc
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current code, setRange and deleteLeaderManager functions
are not waiting for the old pods to disappear and new ones to become
available. Due to that, tests using this functions don't have any
webhook available or worse, they are being served by the old one.
This issue was not exposed due to Eventually we have around all the
Create calls.