Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop namespace annotations #204

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

phoracek
Copy link
Member

What this PR does / why we need it:

Fixing BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1847594

We should not sneak into the restricted space.

Special notes for your reviewer:

Release note:

Drop runtime level label from Namespace

@kubevirt-bot kubevirt-bot requested review from qinqon and RamLavi June 22, 2020 11:55
@phoracek phoracek changed the title drop runlevel annotations drop namespace annotations Jun 22, 2020
@RamLavi
Copy link
Member

RamLavi commented Jun 22, 2020

@phoracek
right now it's ok to insert this because there is no way KMP would try to allocate its own pods since their namespace in not opted in.
But we need to come up with another way to do that should we remove the opt-in feature in the future.

@phoracek
Copy link
Member Author

We can rollback to what we used to do before this label. We had our own that we placed on our namepsace and used it for the anti-selector.

@RamLavi
Copy link
Member

RamLavi commented Jun 22, 2020

/lgtm
/approve
/cherry-pick release-v0.14.0

@kubevirt-bot
Copy link
Collaborator

@RamLavi: once the present PR merges, I will cherry-pick it on top of release-v0.14.0 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherry-pick release-v0.14.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RamLavi
Copy link
Member

RamLavi commented Jun 22, 2020

/lgtm
/approve

@phoracek please run make generate generate-test generate-deploy to make sure all manifests are up to date in order for the travis to pass

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@phoracek
Copy link
Member Author

@RamLavi there was some reformatting introduced in a previous PR. Weird that it passed. Should be fixed now.

Fixing BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1847594

We should not sneak into the restricted space.

Signed-off-by: Petr Horacek <[email protected]>
@RamLavi
Copy link
Member

RamLavi commented Jun 22, 2020

/lgtm

@kubevirt-bot kubevirt-bot merged commit f491b8a into k8snetworkplumbingwg:master Jun 22, 2020
@kubevirt-bot
Copy link
Collaborator

@RamLavi: new pull request created: #206

In response to this:

/lgtm
/approve
/cherry-pick release-v0.14.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants