-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop namespace annotations #204
drop namespace annotations #204
Conversation
@phoracek |
We can rollback to what we used to do before this label. We had our own that we placed on our namepsace and used it for the anti-selector. |
/lgtm |
@RamLavi: once the present PR merges, I will cherry-pick it on top of release-v0.14.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm @phoracek please run |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@RamLavi there was some reformatting introduced in a previous PR. Weird that it passed. Should be fixed now. |
Fixing BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1847594 We should not sneak into the restricted space. Signed-off-by: Petr Horacek <[email protected]>
/lgtm |
@RamLavi: new pull request created: #206 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Fixing BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1847594
We should not sneak into the restricted space.
Special notes for your reviewer:
Release note: