README: production user should change mac range #191
Conversation
It is important to set a distinct seemingly-random range for each cluster. If nearby clusters are deployed with the same range and using Layer 2 CNIs, inter-cluster collision would be likely. This PR states this explicitly and provides bash code to do that. While at it, this PR also makes the relevant section more readable. Signed-Off-By: Dan Kenigsberg <[email protected]>
|
Hi @dankenigsberg. Thanks for your PR. I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
| For example [Multus](https://github.com/intel/multus-cni). | ||
| To deploy multus on a kubernetes cluster with flannel cni. | ||
| * Install any supported [Network Plumbing Working Group de-facto standard](https://github.com/k8snetworkplumbingwg/multi-net-spec) implementation, for example [Multus](https://github.com/intel/multus-cni). | ||
| To deploy multus on a kubernetes cluster with flannel cni: |
There was a problem hiding this comment.
We should consider use another CNI in this example (e.g., Calico), to prevent readers from encountering compatibility issues with Flannel and Kubernetes (1.16 and above).
There is an opened issue about it in Flannel repo [1].
There was a problem hiding this comment.
I hope this can wait for another PR. This PR is only about setting a random-like mac range.
|
/lgtm |
| For example [Multus](https://github.com/intel/multus-cni). | ||
| To deploy multus on a kubernetes cluster with flannel cni. | ||
| * Install any supported [Network Plumbing Working Group de-facto standard](https://github.com/k8snetworkplumbingwg/multi-net-spec) implementation, for example [Multus](https://github.com/intel/multus-cni). | ||
| To deploy multus on a kubernetes cluster with flannel cni: | ||
| ```bash | ||
| kubectl apply -f https://raw.githubusercontent.com/k8snetworkplumbingwg/kubemacpool/master/hack/multus/kubernetes-multus.yaml | ||
| kubectl apply -f https://raw.githubusercontent.com/k8snetworkplumbingwg/kubemacpool/master/hack/multus/multus.yaml |
There was a problem hiding this comment.
I think we need to refresh this, but that's for another PR.
hades01:kubemacpool $ kubectl apply -f https://raw.githubusercontent.com/k8snetworkplumbingwg/kubemacpool/master/hack/multus/multus.yaml
Warning: kubectl apply should be used on resource created by either kubectl create --save-config or kubectl apply
customresourcedefinition.apiextensions.k8s.io/network-attachment-definitions.k8s.cni.cncf.io configured
Warning: kubectl apply should be used on resource created by either kubectl create --save-config or kubectl apply
clusterrole.rbac.authorization.k8s.io/multus configured
Warning: kubectl apply should be used on resource created by either kubectl create --save-config or kubectl apply
clusterrolebinding.rbac.authorization.k8s.io/multus configured
serviceaccount/multus created
error: unable to recognize "https://raw.githubusercontent.com/k8snetworkplumbingwg/kubemacpool/master/hack/multus/multus.yaml": no matches for kind "DaemonSet" in version "extensions/v1beta1"
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/release-note-none |
kubevirt-bot
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
It is important to set a distinct seemingly-random range for each cluster.
If nearby clusters are deployed with the same range and using Layer 2 CNIs, inter-cluster collision would be likely.
This PR states this explicitly and provides bash code to do that. While at it, this PR also makes the relevant section more readable.
Signed-off-by: Dan Kenigsberg [email protected]
What this PR does / why we need it:
Special notes for your reviewer:
Release note: